More tests for Index, tighten up dir minus method #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emstoudenmire
approved these changes
Jul 25, 2019
|
This broke because of the removed export. I'll rebase and fix. |
|
Yes my fault on that. I direct pushed a fix to that issue and restarted the Travis builds. |
|
OK should be good to go |
|
This is why you don't direct push and always open a PR! 😛 |
|
Haha fair! I’ll do that more often from now on, especially when we have
other PRs open.
On Thu, Jul 25, 2019 at 11:40 AM Katharine Hyatt ***@***.***> wrote:
This is why you don't direct push and always open a PR! 😛
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#24?email_source=notifications&email_token=AAHJ3RNMIIO7LA3KFKPYC5LQBHCPZA5CNFSM4IG3WTNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2Z3ZTQ#issuecomment-515095758>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHJ3RN4BAYZ3KMJWKKJWKDQBHCPZANCNFSM4IG3WTNA>
.
|
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 73.49% 73.62% +0.13%
==========================================
Files 26 26
Lines 2056 2055 -1
==========================================
+ Hits 1511 1513 +2
+ Misses 545 542 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.