Skip to content

Adopt default container/routing files path to Symfony Flex #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2017
Merged

Adopt default container/routing files path to Symfony Flex #993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/fr/adrienbrault/idea/symfony2plugin/Settings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,14 @@ public class Settings implements PersistentStateComponent<Settings> {
public static String[] DEFAULT_CONTAINER_PATHS = new String[] {
"app/cache/dev/appDevDebugProjectContainer.xml",
"var/cache/dev/appDevDebugProjectContainer.xml",
"var/cache/dev/srcDevDebugProjectContainer.xml",
};

// Symfony 2 and 3 paths
public static String[] DEFAULT_ROUTES = new String[] {
"app/cache/dev/appDevUrlGenerator.php",
"var/cache/dev/appDevUrlGenerator.php",
"var/cache/dev/srcDevDebugProjectContainerUrlGenerator.php",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure about DebugProjectContainer here ? This looks weird to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh, yees, seems to typo, will check later for real name

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, probably srcDevUrlGenerator.php, as the only change is the kernel name (because of the kernel move from app to src)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, the comment before should say Symfony 2, 3 and 4 paths 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like path is right.

default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stof even more, Symfony 3.3 has similar naming

default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, actually 2.7 has this change too symfony/symfony#20147

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, indeed. But then, it means you have to add more paths to account for them in other places.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #1014

};

/**
Expand Down