Skip to content

Drop python3.11 temporarily #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Conversation

aabmass
Copy link
Collaborator

@aabmass aabmass commented Nov 4, 2022

Until googleapis/proto-plus-python#326 is fixed, client libraries don't properly support 3.11

@aabmass aabmass marked this pull request as ready for review November 4, 2022 21:56
@aabmass aabmass requested a review from a team November 4, 2022 21:56
@aabmass aabmass enabled auto-merge (squash) November 4, 2022 21:58
@punya
Copy link
Contributor

punya commented Nov 5, 2022

Should we temporarily mark that check as not required, instead of removing it altogether?

@aabmass
Copy link
Collaborator Author

aabmass commented Nov 5, 2022

I'm hoping to release this code soon, probably before this issue is fixed. I don't want to claim 3.11 is supported if it wont' actually work

@aabmass
Copy link
Collaborator Author

aabmass commented Nov 7, 2022

@punya if it looks OK, can you approve?

@aabmass aabmass merged commit 339f347 into GoogleCloudPlatform:main Nov 7, 2022
@aabmass aabmass deleted the remove311 branch November 7, 2022 18:51
aabmass added a commit to aabmass/opentelemetry-operations-python that referenced this pull request Apr 24, 2023
aabmass added a commit to aabmass/opentelemetry-operations-python that referenced this pull request Apr 24, 2023
aabmass added a commit that referenced this pull request Apr 25, 2023
* Revert "Drop python3.11 temporarily (#205)"

This reverts commit 339f347.

* update changelogs
shevisj pushed a commit to shevisj/opentelemetry-operations-python that referenced this pull request Apr 25, 2023
…eCloudPlatform#240)

* Revert "Drop python3.11 temporarily (GoogleCloudPlatform#205)"

This reverts commit 339f347.

* update changelogs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants