Adding request layout POCs to scaffolding #2488
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removing rectangle a few other things * adding layout adjustments based on real-world scenarios * removing console logs * replacing the name Center for ContentBlock * modified to remove dev ovverrides
* updating space for ga * semantic tags in the layout components * allowing passthrough of data, aria, id, and role. * unsafe styles and classnames. no more media queries, prop passthrough, semantic elements * final cleanup on layout addressing * adding some additional feedback * actually making these new props work * readding collapse below * adding missing styles * updating common types to be more specific * making types a bit more specific and adding js doc comments for them * updating Cover.Center to follow the same patterns as the rest * adding better types * removing unnecessary processing step * removing unnecessary processing step * updating prop name * Add andText to story default args * adding the latest item --------- Co-authored-by: Jacob Deichert <[email protected]>
Available types:
|
Deploying atlantis with
|
| Latest commit: |
0923efe
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bb2f4fbb.atlantis.pages.dev |
| Branch Preview URL: | https://taylor-scaffolding-objects.atlantis.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
Changes
Added
Changed
Deprecated
Removed
Fixed
Security
Testing
Changes can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.