-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Feature/fixing clang gnu compiler warnings #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aggarg
merged 32 commits into
FreeRTOS:main
from
phelter:feature/fixing-clang-gnu-compiler-warnings
Feb 23, 2023
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
1342407
Adding in ability to support a library for freertos_config and a cust…
phelter 1822d8e
Using single name definition for libraries everywhere. (#558)
phelter 50a29ef
Supporting backwards compatibility with FREERTOS_CONFIG_FILE_DIRECTOR…
phelter 06f9314
Removing compiler warnings for GNU and Clang. (#571)
phelter b625d2a
Merge branch 'main' into feature/cmake-updates
aggarg ae8eb33
Merge branch 'main' into feature/cmake-updates
phelter 855d6d5
Merge branch 'main' into feature/cmake-updates
phelter a3db429
Added in documentation on how to consume from a main project. Added d…
phelter 2310f17
Merge branch 'main' into feature/cmake-updates
aggarg b2c564c
Only adding freertos_config if it exists. Removing auto generation of…
phelter 8c3c2c1
Fixing clang and gnu compiler warnings.
phelter 2e2aa7a
Adding in project information and how to compile for GNU/clang
phelter 89ac587
Fixing compiler issue with unused variable - no need to declare varia…
phelter 8952634
Adding in compile warnings for linux builds that kernel is okay with …
phelter 6d60ad8
Fixing more extra-semi-stmt clang warnings.
phelter 4bddfa3
Moving definition of hooks into header files if features are enabled.
phelter 5b7045c
Fixing formatting with uncrustify.
phelter 32ecc3e
Merge remote-tracking branch 'origin/main' into feature/fixing-clang-…
phelter ec7de59
Fixing merge conflicts with main merge.
phelter c3a0d94
Fixing compiler errors due to merge issues and formatting.
phelter 0f5b7cf
Fixing Line feeds.
phelter eb83cad
Adding 'portNORETURN' into portmacros.h. Other Updates based on PR re…
phelter fc687af
Merge branch 'main' into feature/fixing-clang-gnu-compiler-warnings
aggarg fda8ac9
Further clean-up of clang and clang-tidy issues.
phelter 608b7d7
Removing compiler specific pragmas from common c files.
phelter 23acff8
Fixing missing lexicon entry and uncrustify formatting changes.
phelter e15209f
Resolving merge issue multiple defnitions of proto for prvIdleTask
phelter 31c6261
Fixing formatting issues that are not covered by uncrustify. Use clan…
phelter 8839aa4
More uncrustify formatting issues.
phelter 1169b3b
Fixing extra bracket in #if statement.
phelter d538ae6
Merge branch 'main' into feature/fixing-clang-gnu-compiler-warnings
phelter 75f2405
Merge branch 'main' into feature/fixing-clang-gnu-compiler-warnings
aggarg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phelter Why do you need C99? We want to support C89. Did you notice anything C99 specific in the kernel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aggarg - Yes- there
were
several cases of: C90 ISO violations ofdeclaration after statement
. See: https://clang.llvm.org/docs/DiagnosticsReference.html#wdeclaration-after-statement These may have since been updated.These can be detected using clang-14 compiles by setting the compile options in the description of this PR.
Feel free to change back to C90 if/when those are updated. I am unaware of any others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the clarification. I did build the kernel with
-Wdeclaration-after-statement
and I see no warning from kernel source. I will remove the following 2 lines which were added in this PR -There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the PR - #633