Skip to content

Synopsys ARC port, adding support for ARC EM and HS cores -- continued from PR #8. #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2020

Conversation

yuhui-zheng
Copy link
Contributor

Since #8 does not have "allow edits from maintainers" enabled, I'm proposing edits in this draft PR.

Changes:

  • Rebase.
  • Move ./portable/Synopsys/ARC to ./portable/ThirdParty/GCC/ARC_EM_HS, since our folder structure as of now is ./portable/<compiler>/<architecture>.

There's no change to source code.

@YuguoWH
Copy link
Contributor

YuguoWH commented Mar 16, 2020

Thank you for the review, I'm ok with this file structure. Actually the ARC port support GCC and MetaWare toolchains, so I'm not sure whether another folder is needed, like ./portable/ThirdParty/MetaWare/ARC_EM_HS

@yuhui-zheng
Copy link
Contributor Author

yuhui-zheng commented Mar 16, 2020

@YuguoWH

I've checked current status for embARC support in FreeRTOS -- https://www.freertos.org/a00090.html#ARC, one option for people land there is to go to your site to obtain the code along with further instructions at https://embarc.org/iot.html. I believe even after merging this PR we would still keep reference to your site at least. So if your site has specific instructructions on MetaWare, we may be fine there.

Another thought is we may not have MetaWare compiler setup in our CI, so we won't be able to test that. I'll forward this discussion to folks, and if it's needed let's have another PR dedicated for MetaWare. (I did find two forms of user agreements at the bottom of this page https://www.synopsys.com/dw/ipdir.php?ds=sw_metaware. May need to go through approval process for setting up.)

Action items for me:

  • Close PR add port for ATMega328P #7 from you, and make this draft PR an official PR.
  • I'll need one more approval from folks for this PR before merging.
  • Will forward discussion for MetaWare.

Questions for you:

  • Out of curiosity, do GCC and MetaWare compile the same source files for a port (e.g. the files in this PR), or does MetaWare need to have minor changes to files in this PR?

  • Do you happen to plan to submit a demo project for your port? (It'll be helpful to embARC users landing on FreeRTOS, they could jump start with a working project.)

@yuhui-zheng yuhui-zheng changed the title Rebase PR #8. Synopsys ARC port, adding support for ARC EM and HS cores -- continued from PR #8. Mar 16, 2020
@yuhui-zheng yuhui-zheng marked this pull request as ready for review March 16, 2020 22:04
@YuguoWH
Copy link
Contributor

YuguoWH commented Mar 17, 2020

Thank you for your advice, I think we can focus on GCC in this PR.
And for your questions:

  • Out of curiosity, do GCC and MetaWare compile the same source files for a port (e.g. the files in this PR), or does MetaWare need to have minor changes to files in this PR?

Yes, there are some macros to seperate compiler specific code so both compilers can work on the same code

  • Do you happen to plan to submit a demo project for your port? (It'll be helpful to embARC users landing on FreeRTOS, they could jump start with a working project.)

Sure, I'll prepare a demo project asap

@yuhui-zheng yuhui-zheng merged commit 464695a into FreeRTOS:master Mar 24, 2020
@yuhui-zheng
Copy link
Contributor Author

@YuguoWH We are going to merge this PR first. Whenever you get a chance for out-of-box project, happy to take a look. That'll give users an easy starting point. Thanks again for this PR, and hopefully we'll hear from you soon.

jefftenney pushed a commit to jefftenney/FreeRTOS-Kernel that referenced this pull request Mar 31, 2020
…d from PR FreeRTOS#8. (FreeRTOS#28)

Synopsys ARC port, adding support for ARC EM and HS cores.
@yuhui-zheng yuhui-zheng deleted the pr_8 branch April 30, 2020 01:56
laroche pushed a commit to laroche/FreeRTOS-Kernel that referenced this pull request Apr 18, 2024
AhmedIsmail02 pushed a commit to AhmedIsmail02/FreeRTOS-Kernel that referenced this pull request Jun 12, 2024
The files will be identical for all apps to be added.

Signed-off-by: Hugues Kamba-Mpiana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants