Skip to content

Updating deps for node 20 #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Updating deps for node 20 #647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7dd3ace
Updating deps for node 20
christhompsongoogle May 8, 2025
2075363
get tests running
jhuleatt May 8, 2025
d6b7477
ignore some ts warnings for now
jhuleatt May 8, 2025
207fca4
downgrade typedoc so we don't get a huge reference docs diff
jhuleatt May 8, 2025
742515e
update versions in workflows
jhuleatt May 8, 2025
28aae71
never mind, keep newer versions of typedoc
jhuleatt May 8, 2025
194873b
don't break old peer deps
jhuleatt May 8, 2025
5b57305
forgot to push lockfile
jhuleatt May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/docs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ jobs:
name: Build
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Setup node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'
cache: 'npm'
- name: Install deps
run: npm ci
Expand Down
22 changes: 11 additions & 11 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,19 @@ jobs:
name: Build
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Setup node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'
cache: 'npm'
- name: Install deps
run: npm ci
- name: Build
id: pack-dir
run: ./build.sh
- name: 'Upload Artifact'
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: reactfire-${{ github.run_id }}
path: |
Expand All @@ -44,14 +44,14 @@ jobs:
needs: build
strategy:
matrix:
node: ["18", "20"]
node: ["20"]
fail-fast: false
name: Test Node.js ${{ matrix.node }} (Ubuntu)
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Setup node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
check-latest: true
Expand All @@ -62,12 +62,12 @@ jobs:
run: npm install
working-directory: ./functions
- name: Firebase emulator cache
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/.cache/firebase/emulators
key: firebase_emulators
- name: 'Download Artifacts'
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
- name: Expand Artifact
run: |
chmod +x reactfire-${{ github.run_id }}/unpack.sh
Expand All @@ -81,12 +81,12 @@ jobs:
if: ${{ github.ref == 'refs/heads/main' || github.event_name == 'release' }}
steps:
- name: Setup node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: '18'
registry-url: 'https://registry.npmjs.org'
- name: 'Download Artifacts'
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
- name: Publish
run: |
cd ./reactfire-${{ github.run_id }}/
Expand Down
Loading
Loading