Skip to content

linker/test: create Session manually to inject a custom diagnostic writer. #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2022
Merged

linker/test: create Session manually to inject a custom diagnostic writer. #956

merged 2 commits into from
Nov 30, 2022

Conversation

eddyb
Copy link
Contributor

@eddyb eddyb commented Nov 30, 2022

This allows us to work around this upstream change (@oisyn ran into it while trying to update the nightly):

(Note that the first commit is from my SPIR-T integration PR, where I already needed that change)

EDIT: opened an issue for moving us off these awkward unit tests:

@oisyn oisyn merged commit dfd285e into EmbarkStudios:main Nov 30, 2022
@eddyb eddyb deleted the linker-tests-manual-session branch November 30, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants