Skip to content

Add missing config options to kconfig #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add missing config options to kconfig #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions Kconfig.projbuild
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
menu "AsyncTCP Configuration"

config ASYNC_TCP_STACK_SIZE
Copy link
Preview

Copilot AI May 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider clarifying in the help text that the stack size is specified in bytes to avoid any ambiguity.

Copilot uses AI. Check for mistakes.

int "Async TCP task stack size"
default 8192
help
This configures stack size of the Async TCP task

choice ASYNC_TCP_RUNNING_CORE
bool "Core on which AsyncTCP's thread is running"
default ASYNC_TCP_RUN_CORE1
Expand Down Expand Up @@ -27,4 +33,23 @@ config ASYNC_TCP_USE_WDT
help
Enable WDT for the AsyncTCP task, so it will trigger if a handler is locking the thread.

config ASYNC_TCP_QUEUE_SIZE
int "Async TCP event queue size"
default 64
help
Configures the size of the Async TCP event queue. Lowering the value will reduce resource use
but will limit the number of events that can be processed. Increasing will allow for more
connections/event to be handled.
Comment on lines +40 to +42
Copy link
Preview

Copilot AI May 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] It might be beneficial to specify the expected units or provide more detail on the range of acceptable values for ASYNC_TCP_QUEUE_SIZE.

Suggested change
Configures the size of the Async TCP event queue. Lowering the value will reduce resource use
but will limit the number of events that can be processed. Increasing will allow for more
connections/event to be handled.
Configures the size of the Async TCP event queue (number of events). Lowering the value will reduce
resource use but will limit the number of events that can be processed. Increasing the value will
allow for more connections/events to be handled. Recommended range: 16 to 256. Default: 64.

Copilot uses AI. Check for mistakes.


config ASYNC_TCP_MAX_ACK_TIME
int "Async TCP max ack time"
default 5000
help
Configures the max time in milliseconds to wait for an ACK response.

config ASYNC_TCP_PRIORITY
int "Async TCP task priority"
default 10
help
This configures the priority of the Async TCP task.
endmenu
Loading