Skip to content

Bump pysnmp for asyncore and py3.12 compatibility #18457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Sep 3, 2024

Conversation

Kyle-Neale
Copy link
Contributor

@Kyle-Neale Kyle-Neale commented Aug 29, 2024

What does this PR do?

Bumps the version of pysnmp so it's compatible with python version 3.12

Motivation

Python 3.12 removes asyncore used by our python implementation of SNMP.

gh-72719: Remove modules asyncore and asynchat, which were deprecated by PEP 594.

lexstudio/pysnmp fork supports asyncore for python 3.12 in version 5.x so we bump to the latest version in which it is supported.

Additional Notes

Until we convert our implementation to use asyncio, we need to stay on 5.1.0 since asyncore is removed in the next major release (6.x).

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.61%. Comparing base (9f3d9f9) to head (7c31051).
Report is 16 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
gearmand ?
hive ?
hivemq ?
hudi ?
ibm_ace ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
snmp 95.71% <ø> (?)
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

github-actions bot commented Sep 3, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

github-actions bot commented Sep 3, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

github-actions bot commented Sep 3, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

github-actions bot commented Sep 3, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

github-actions bot commented Sep 3, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

github-actions bot commented Sep 3, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link

github-actions bot commented Sep 3, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@Kyle-Neale Kyle-Neale mentioned this pull request Sep 3, 2024
4 tasks
@Kyle-Neale Kyle-Neale changed the title Bump pysnmp for asyncio and py3.12 compatibility Bump pysnmp for asyncore and py3.12 compatibility Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@Kyle-Neale Kyle-Neale merged commit 61d32ff into master Sep 3, 2024
45 checks passed
@Kyle-Neale Kyle-Neale deleted the kyleneale/bump_pysnmp_version branch September 3, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants