Skip to content

chore(tracing): remove deprecated modules [3.0] #12111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Jan 27, 2025

  • Removes all tracing modules and packages that are not defined in ddtrace._trace, ddtrace.internal, or ddtrace.trace.
  • Removes deprecated tracing attributes from ddtrace. ddtrace.trace should be the sole public interface for tracing.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@mabdinur mabdinur changed the title chore(tracing): remove deprecated modules 3.0 chore(tracing): remove deprecated modules [3.0] Jan 27, 2025
Copy link
Contributor

github-actions bot commented Jan 27, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/remove-deprecated-tracing-modules-a129231d42e1218d.yaml  @DataDog/apm-python
benchmarks/sampling_rule_matches/scenario.py                            @DataDog/apm-core-python
ddtrace/__init__.py                                                     @DataDog/apm-core-python
ddtrace/constants.py                                                    @DataDog/apm-core-python
tests/suitespec.yml                                                     @DataDog/python-guild @DataDog/apm-core-python
tests/tracer/test_tracer.py                                             @DataDog/apm-sdk-api-python

@mabdinur mabdinur changed the base branch from main to munir/avoid-using-deprecated-apis-internally January 27, 2025 22:30
@mabdinur mabdinur changed the base branch from munir/avoid-using-deprecated-apis-internally to munir/ensure-all-integrations-have-patch-module January 27, 2025 23:11
@pr-commenter
Copy link

pr-commenter bot commented Jan 27, 2025

Benchmarks

Benchmark execution time: 2025-01-31 02:51:19

Comparing candidate commit 75a8bf3 in PR branch munir/remove-deprecated-tracing-modules with baseline commit ff6120c in branch munir/upgrade-min-aws-lambda.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@mabdinur mabdinur force-pushed the munir/remove-deprecated-tracing-modules branch from fa00ac0 to f432a4d Compare January 27, 2025 23:14
@mabdinur mabdinur force-pushed the munir/remove-deprecated-tracing-modules branch from f432a4d to c092d57 Compare January 27, 2025 23:23
@mabdinur mabdinur changed the base branch from munir/ensure-all-integrations-have-patch-module to munir/avoid-using-deprecated-apis-internally January 27, 2025 23:24
@mabdinur mabdinur force-pushed the munir/remove-deprecated-tracing-modules branch from e079846 to c092d57 Compare January 27, 2025 23:36
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 28, 2025

Datadog Report

Branch report: munir/remove-deprecated-tracing-modules
Commit report: 75a8bf3
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 37.2s Total duration (35m 44.18s time saved)

@mabdinur mabdinur force-pushed the munir/avoid-using-deprecated-apis-internally branch from 7954ec6 to 60d3a9c Compare January 28, 2025 15:26
@mabdinur mabdinur force-pushed the munir/avoid-using-deprecated-apis-internally branch from 60d3a9c to 8351e5c Compare January 28, 2025 15:27
@mabdinur mabdinur force-pushed the munir/avoid-using-deprecated-apis-internally branch 2 times, most recently from a651cc6 to 163f420 Compare January 29, 2025 18:29
update pin and circular imports
@mabdinur mabdinur force-pushed the munir/avoid-using-deprecated-apis-internally branch from 163f420 to 2b94d7f Compare January 29, 2025 18:31
Base automatically changed from munir/avoid-using-deprecated-apis-internally to 3.x-staging January 29, 2025 21:34
@mabdinur mabdinur marked this pull request as ready for review January 29, 2025 23:05
@mabdinur mabdinur requested review from a team as code owners January 29, 2025 23:05
@mabdinur mabdinur changed the base branch from 3.x-staging to munir/upgrade-min-aws-lambda January 31, 2025 02:02
@mabdinur mabdinur merged commit ff14361 into munir/upgrade-min-aws-lambda Jan 31, 2025
686 checks passed
@mabdinur mabdinur deleted the munir/remove-deprecated-tracing-modules branch January 31, 2025 15:02
@mabdinur mabdinur restored the munir/remove-deprecated-tracing-modules branch January 31, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants