chore(tracer): deprecates patch_all #11918

ZStriker19 · 2025-01-13T18:23:48Z

Checklist

PR author has checked that all the criteria below are met
The PR description includes an overview of the change
The PR description articulates the motivation for the change
The change includes tests OR the PR description describes a testing strategy
The PR description notes risks associated with the change, if any
Newly-added code is easy to change
The change follows the library release note guidelines
The change includes or references documentation updates if necessary
Backport labels are set (if applicable)

Reviewer Checklist

Reviewer has checked that all the criteria below are met
Title is accurate
All changes are related to the pull request's stated goal
Avoids breaking API changes
Testing strategy adequately addresses listed risks
Newly-added code is easy to change
Release note makes sense to a user of the library
If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
Backport labels are set in a manner that is consistent with the release branch maintenance policy

github-actions · 2025-01-13T18:24:21Z

CODEOWNERS have been resolved as:

releasenotes/notes/deprecate_patch_all-244eddcfacb1da14.yaml            @DataDog/apm-python
benchmarks/ddtrace_run/scenario.py                                      @DataDog/apm-core-python
ddtrace/_monkey.py                                                      @DataDog/apm-core-python
ddtrace/bootstrap/preload.py                                            @DataDog/apm-core-python
ddtrace/contrib/_aws_lambda.py                                          @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_httplib.py                                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_kombu.py                                               @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_sanic.py                                               @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_snowflake.py                                           @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/_urllib3.py                                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/pytest/plugin.py                               @DataDog/ci-app-libraries
docs/api.rst                                                            @DataDog/python-guild
tests/appsec/iast/fixtures/entrypoint/views.py                          @DataDog/asm-python
tests/commands/test_runner.py                                           @DataDog/apm-core-python
tests/contrib/algoliasearch/test.py                                     @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/django/test_django.py                                     @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/psycopg/test_psycopg_snapshot.py                          @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/psycopg2/test_psycopg.py                                  @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/psycopg2/test_psycopg_snapshot.py                         @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/starlette/test_starlette.py                               @DataDog/apm-core-python @DataDog/apm-idm-python
tests/tracer/test_monkey.py                                             @DataDog/apm-sdk-api-python

datadog-dd-trace-py-rkomorn · 2025-01-13T18:57:42Z

Datadog Report

Branch report: zachg/deprecate_patch_all
Commit report: 5b7f14c
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 47.85s Total duration (35m 39s time saved)

pr-commenter · 2025-01-13T19:23:04Z

Benchmarks

Benchmark execution time: 2025-03-25 16:19:43

Comparing candidate commit 7331c80 in PR branch zachg/deprecate_patch_all with baseline commit 0289159 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 496 metrics, 2 unstable metrics.

ddtrace/__init__.py

…all integrations [3.0] (#11916) Requires: [chore: avoids using deprecated modules in tests and log injection [3.0 prep]](#11835). Follow up to: #11918 This change internalizes the following functions: - `ddtrace.contrib.<integration_name>.patch()` - `ddtrace.contrib.<integration_name>.unpatch()` - `ddtrace.contrib.<integration_name>.get_version()` This change also internalizes all integrations that only expose `patch()`, `unpatch()`, and `get_version()` functions. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

datadog-dd-trace-py-rkomorn · 2025-01-30T21:30:31Z

Datadog Report

Branch report: zachg/deprecate_patch_all
Commit report: 470f077
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1184 Skipped, 3m 18.75s Total duration (25m 29.24s time saved)

rn chore(iast): taint parameter name in post requests in fastapi (#12038) Continuation of #12009 - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) still expose patch_all since it's just deprecated change imports for _patch_all clean up where it's called in strings fix up more tests

ddtrace/contrib/_snowflake.py

ddtrace/contrib/_httplib.py

ddtrace/contrib/_aws_lambda.py

ddtrace/_monkey.py

github-actions · 2025-03-24T18:35:06Z

Bootstrap import analysis

Comparison of import times between this PR and main.

Summary

The average import time in this PR is: 243 ± 4 ms.

The average import time in main is: 244 ± 3 ms.

The import time difference between this PR and main is: -1.5 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.943 ms (0.80%)

ddtrace.bootstrap.sitecustomize 1.291 ms (0.53%)

ddtrace.bootstrap.preload 1.291 ms (0.53%)

ddtrace.internal.products 1.291 ms (0.53%)

ddtrace.internal.remoteconfig.client 0.634 ms (0.26%)

ddtrace 0.652 ms (0.27%)

tests/appsec/iast/fixtures/entrypoint/views.py

Co-authored-by: Alberto Vara <[email protected]>

ZStriker19 force-pushed the zachg/deprecate_patch_all branch from 12513d0 to fb33c53 Compare January 13, 2025 18:43

ZStriker19 changed the title ~~chore(tracer): deprecate patch_all~~ chore(tracer): deprecates patch_all Jan 13, 2025

ZStriker19 changed the title ~~chore(tracer): deprecates patch_all~~ chore(tracer): deprecates patch_all [3.0] Jan 13, 2025

mabdinur mentioned this pull request Jan 13, 2025

chore(integrations): make implementation details internal [3.0] #11916

Merged

2 tasks

ZStriker19 changed the title ~~chore(tracer): deprecates patch_all [3.0]~~ chore(tracer): deprecates patch_all Jan 16, 2025

ZStriker19 mentioned this pull request Jan 17, 2025

use ddtrace.auto since patch_all is being deprecated DataDog/datadog-lambda-python#551

Closed

11 tasks

purple4reina reviewed Jan 17, 2025

View reviewed changes

ddtrace/__init__.py Outdated Show resolved Hide resolved

ZStriker19 force-pushed the zachg/deprecate_patch_all branch from 0fc6915 to 05f315e Compare February 3, 2025 21:16

ZStriker19 force-pushed the zachg/deprecate_patch_all branch from 05f315e to 8995916 Compare February 3, 2025 21:24

ZStriker19 changed the base branch from main to 3.x-staging February 3, 2025 21:24

ZStriker19 and others added 5 commits February 3, 2025 16:28

touch up afer merge conflict resolutions

d60648c

typing

03c1f82

build docs fixes

66b5c30

Merge branch '3.x-staging' into zachg/deprecate_patch_all

95ff462

fix django str tests

483788b

ZStriker19 marked this pull request as ready for review February 4, 2025 22:49

ZStriker19 requested review from a team as code owners February 4, 2025 22:49

ZStriker19 requested review from rachelyangdog and juanjux February 4, 2025 22:49

ZStriker19 requested review from a team as code owners February 6, 2025 21:08

ZStriker19 requested a review from juan-fernandez February 6, 2025 21:08

ZStriker19 force-pushed the zachg/deprecate_patch_all branch from 8a08f67 to efef2eb Compare February 6, 2025 21:11

Merge branch 'main' into zachg/deprecate_patch_all

0d3e8dc

ZStriker19 enabled auto-merge (squash) February 6, 2025 22:00

ZStriker19 commented Feb 6, 2025

View reviewed changes

ddtrace/contrib/_snowflake.py Outdated Show resolved Hide resolved

Update ddtrace/contrib/_snowflake.py

9622613

ZStriker19 commented Feb 6, 2025

View reviewed changes

ddtrace/contrib/_httplib.py Outdated Show resolved Hide resolved

Update ddtrace/contrib/_httplib.py

2f9f528

mabdinur reviewed Feb 6, 2025

View reviewed changes

ddtrace/contrib/_aws_lambda.py Outdated Show resolved Hide resolved

ZStriker19 and others added 3 commits February 6, 2025 17:17

update aws_lambda doc

ff4d92e

lint

4aef9d3

Merge branch 'main' into zachg/deprecate_patch_all

470f077

mabdinur approved these changes Feb 11, 2025

View reviewed changes

ddtrace/_monkey.py Outdated Show resolved Hide resolved

Merge branch 'main' into zachg/deprecate_patch_all

f7a3f7e

fix method typing

7b36d24

avara1986 approved these changes Mar 25, 2025

View reviewed changes

avara1986 reviewed Mar 25, 2025

View reviewed changes

tests/appsec/iast/fixtures/entrypoint/views.py Outdated Show resolved Hide resolved

avara1986 reviewed Mar 25, 2025

View reviewed changes

tests/appsec/iast/fixtures/entrypoint/views.py Outdated Show resolved Hide resolved

taegyunkim approved these changes Mar 25, 2025

View reviewed changes

gnufede approved these changes Mar 25, 2025

View reviewed changes

ZStriker19 and others added 4 commits March 25, 2025 11:26

Update tests/appsec/iast/fixtures/entrypoint/views.py

8f13a72

Co-authored-by: Alberto Vara <[email protected]>

Update tests/appsec/iast/fixtures/entrypoint/views.py

1d7d4ee

Co-authored-by: Alberto Vara <[email protected]>

Merge branch 'main' into zachg/deprecate_patch_all

f2edaf7

lint

7331c80

ZStriker19 merged commit e987057 into main Mar 25, 2025
820 checks passed

ZStriker19 deleted the zachg/deprecate_patch_all branch March 25, 2025 16:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(tracer): deprecates patch_all #11918

chore(tracer): deprecates patch_all #11918

ZStriker19 commented Jan 13, 2025 •

edited

Loading

github-actions bot commented Jan 13, 2025 •

edited

Loading

datadog-dd-trace-py-rkomorn bot commented Jan 13, 2025 •

edited

Loading

pr-commenter bot commented Jan 13, 2025 •

edited

Loading

datadog-dd-trace-py-rkomorn bot commented Jan 30, 2025 •

edited

Loading

github-actions bot commented Mar 24, 2025 •

edited

Loading

chore(tracer): deprecates patch_all #11918

chore(tracer): deprecates patch_all #11918

Conversation

ZStriker19 commented Jan 13, 2025 • edited Loading

Checklist

Reviewer Checklist

github-actions bot commented Jan 13, 2025 • edited Loading

datadog-dd-trace-py-rkomorn bot commented Jan 13, 2025 • edited Loading

Datadog Report

pr-commenter bot commented Jan 13, 2025 • edited Loading

Benchmarks

datadog-dd-trace-py-rkomorn bot commented Jan 30, 2025 • edited Loading

Datadog Report

github-actions bot commented Mar 24, 2025 • edited Loading

Bootstrap import analysis

Summary

Import time breakdown

ZStriker19 commented Jan 13, 2025 •

edited

Loading

github-actions bot commented Jan 13, 2025 •

edited

Loading

datadog-dd-trace-py-rkomorn bot commented Jan 13, 2025 •

edited

Loading

pr-commenter bot commented Jan 13, 2025 •

edited

Loading

datadog-dd-trace-py-rkomorn bot commented Jan 30, 2025 •

edited

Loading

github-actions bot commented Mar 24, 2025 •

edited

Loading