Skip to content

chore(tracing): deprecate DD_TRACE_SPAN_AGGREGATOR_RLOCK #10725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Sep 19, 2024

DD_TRACE_SPAN_AGGREGATOR_RLOCK configuration exposes tracer implementation details. ddtrace user's should not care about what type of lock is acquired to aggregate span data. This functionality should just work.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Sep 19, 2024

CODEOWNERS have been resolved as:

releasenotes/notes/deprecate-DD_TRACE_SPAN_AGGREGATOR_RLOCK-eb1ca91f7c1dd2b0.yaml  @DataDog/apm-python
ddtrace/settings/config.py                                              @DataDog/python-guild @DataDog/apm-sdk-api-python
docs/configuration.rst                                                  @DataDog/python-guild
tests/contrib/gunicorn/test_gunicorn.py                                 @DataDog/apm-core-python @DataDog/apm-idm-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 19, 2024

Datadog Report

Branch report: munir/deprecate-DD_TRACE_SPAN_AGGREGATOR_RLOCK
Commit report: 1365a55
Test service: dd-trace-py

✅ 0 Failed, 592 Passed, 694 Skipped, 19m 2.06s Total duration (18m 24.06s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Sep 19, 2024

Benchmarks

Benchmark execution time: 2024-09-20 19:49:21

Comparing candidate commit 1365a55 in PR branch munir/deprecate-DD_TRACE_SPAN_AGGREGATOR_RLOCK with baseline commit 33daba9 in branch main.

Found 4 performance improvements and 0 performance regressions! Performance is the same for 352 metrics, 48 unstable metrics.

scenario:iast_aspects-aspect_iast_do_add_and_uppercase

  • 🟩 max_rss_usage [-2.629MB; -2.305MB] or [-8.841%; -7.752%]

scenario:iast_aspects-aspect_iast_do_center

  • 🟩 max_rss_usage [-2.638MB; -2.350MB] or [-8.860%; -7.893%]

scenario:iast_aspects-aspect_iast_do_index

  • 🟩 max_rss_usage [-2.666MB; -2.379MB] or [-8.947%; -7.985%]

scenario:iast_aspects-aspect_iast_do_ljust

  • 🟩 max_rss_usage [-2.797MB; -2.489MB] or [-9.385%; -8.353%]

@mabdinur mabdinur marked this pull request as ready for review September 20, 2024 16:13
@mabdinur mabdinur requested review from a team as code owners September 20, 2024 16:13
@mabdinur mabdinur enabled auto-merge (squash) September 20, 2024 16:13
@mabdinur mabdinur requested review from a team as code owners September 20, 2024 16:18
@mabdinur mabdinur force-pushed the munir/deprecate-DD_TRACE_SPAN_AGGREGATOR_RLOCK branch from 1958f10 to 3be2dcd Compare September 20, 2024 17:42
@mabdinur mabdinur merged commit 0a9453b into main Sep 23, 2024
520 of 522 checks passed
@mabdinur mabdinur deleted the munir/deprecate-DD_TRACE_SPAN_AGGREGATOR_RLOCK branch September 23, 2024 19:40
mabdinur added a commit that referenced this pull request Sep 25, 2024
DD_TRACE_SPAN_AGGREGATOR_RLOCK configuration exposes tracer
implementation details. ddtrace user's should not care about what type
of lock is acquired to aggregate span data. This functionality should
just work.

## Checklist
- [ ] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants