-
Notifications
You must be signed in to change notification settings - Fork 437
chore(tracing): deprecate DD_TRACE_SPAN_AGGREGATOR_RLOCK #10725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tracing): deprecate DD_TRACE_SPAN_AGGREGATOR_RLOCK #10725
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 592 Passed, 694 Skipped, 19m 2.06s Total duration (18m 24.06s time saved) |
BenchmarksBenchmark execution time: 2024-09-20 19:49:21 Comparing candidate commit 1365a55 in PR branch Found 4 performance improvements and 0 performance regressions! Performance is the same for 352 metrics, 48 unstable metrics. scenario:iast_aspects-aspect_iast_do_add_and_uppercase
scenario:iast_aspects-aspect_iast_do_center
scenario:iast_aspects-aspect_iast_do_index
scenario:iast_aspects-aspect_iast_do_ljust
|
1958f10
to
3be2dcd
Compare
releasenotes/notes/deprecate-DD_TRACE_SPAN_AGGREGATOR_RLOCK-eb1ca91f7c1dd2b0.yaml
Outdated
Show resolved
Hide resolved
…1ca91f7c1dd2b0.yaml Co-authored-by: erikayasuda <[email protected]>
DD_TRACE_SPAN_AGGREGATOR_RLOCK configuration exposes tracer implementation details. ddtrace user's should not care about what type of lock is acquired to aggregate span data. This functionality should just work. ## Checklist - [ ] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
DD_TRACE_SPAN_AGGREGATOR_RLOCK configuration exposes tracer implementation details. ddtrace user's should not care about what type of lock is acquired to aggregate span data. This functionality should just work.
Checklist
Reviewer Checklist