-
Notifications
You must be signed in to change notification settings - Fork 45
breaking: Use sha256 to hash StepFunctions trace id and manually set _dd.p.tid
#490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimi-p
commented
May 23, 2024
kimi-p
commented
May 23, 2024
_dd.p.tid
agocs
approved these changes
May 24, 2024
nine5two7
reviewed
May 30, 2024
nine5two7
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
duncanista
approved these changes
Jun 4, 2024
11 tasks
_dd.p.tid
_dd.p.tid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
trace_id
:0
._dd.p.tid
tag.parent_id
(which isaws.stepfunctions.lambda
span's span_id in this case):0
.Motivation
To support 128 bits trace IDs and to avoid showing up in security vulnerability scans, we are upgrading the hashing method (md5) to sha256.
Testing Guidelines
Tested in staging. The example trace is from a Step Function that triggers two Lambdas. One using NodeJS; another using Python.
Additional Notes
Types of Changes
Check all that apply