Skip to content

Disable API security by default #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Disable API security by default #424

merged 1 commit into from
Mar 5, 2024

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Mar 4, 2024

What does this PR do?

This was enabled by default in dd-trace-py, but doesn't apply to lambda and is responsible for about a 128ms cold start increase.
This will disable it unless the user explicitly opts-in.

Motivation

I want this to go fast.

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@astuyve astuyve requested a review from a team as a code owner March 4, 2024 21:49
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joeyzhao2018
Copy link
Contributor

joeyzhao2018 commented Mar 5, 2024

did we compare the resulted cold start time? asking because i wonder if the env is read "early" enough

ignore above. just saw the comparison in slack channel.

@astuyve
Copy link
Contributor Author

astuyve commented Mar 5, 2024

Yeah I had to move it from tracing.py to here

@astuyve astuyve merged commit a06668d into main Mar 5, 2024
@astuyve astuyve deleted the aj/disable-api-security branch March 5, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants