Skip to content

Improve error log message when no sns->sqs context found. #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

purple4reina
Copy link
Contributor

What does this PR do?

Instead of logging

Datadog Lambda Python only supports extracting trace context from String or Binary SQS/SNS message attributes

The tracer extractor returned with error local variable 'dd_json_data' referenced before assignment

log

The tracer extractor returned with error Datadog Lambda Python only supports extracting trace context from String or Binary SQS/SNS message attributes

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@purple4reina purple4reina requested a review from a team as a code owner November 21, 2023 20:09
Copy link
Contributor

@astuyve astuyve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay here, not sure how heavy throwing an exception is (kind of cpu intensive in node), but the logic is sound

@purple4reina purple4reina force-pushed the rey.abolofia/better-logging branch from 7f3223b to f4facef Compare November 21, 2023 20:16
@purple4reina purple4reina force-pushed the rey.abolofia/better-logging branch from f4facef to dfef34f Compare November 21, 2023 20:18
@purple4reina purple4reina merged commit 9968bbc into main Nov 21, 2023
@purple4reina purple4reina deleted the rey.abolofia/better-logging branch November 21, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants