Skip to content

feat: Drop py3.7 #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 12, 2023
Merged

feat: Drop py3.7 #395

merged 8 commits into from
Dec 12, 2023

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Nov 21, 2023

…e ago

What does this PR do?

Python 3.7 is now in phase 1 deprecation, so we do not plan on releasing new features or fixes as there is no continued security or technical support from AWS, and we cannot create new 3.7 functions.

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@astuyve astuyve marked this pull request as ready for review December 12, 2023 14:26
@astuyve astuyve requested a review from a team as a code owner December 12, 2023 14:26
@astuyve astuyve changed the title feat: Drop py3.7 from build script as we stopped publishing it a whil… feat: Drop py3.7 Dec 12, 2023
@duncanista
Copy link
Contributor

Looks good, nit:

if version_info >= (3, 7): # current implementation only support version > 3.7

Do we need too change something here?

@duncanista
Copy link
Contributor

Another nit:

# Example: VERSION=1 REGIONS=us-east-1 LAYERS=Datadog-Python37 ./scripts/publish_layers.sh

Maybe we can change this too?

Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@astuyve
Copy link
Contributor Author

astuyve commented Dec 12, 2023

Looks good, nit:

if version_info >= (3, 7): # current implementation only support version > 3.7

Do we need too change something here?

I debated this. With the poetry changes, users shouldn't be able to manually include this library in py3.7 functions so it's probably fine. Will remove

@astuyve astuyve merged commit 8d38aa9 into main Dec 12, 2023
@astuyve astuyve deleted the aj/drop37-from-build branch December 12, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants