-
Notifications
You must be signed in to change notification settings - Fork 45
feat: Drop py3.7 #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Drop py3.7 #395
Conversation
Looks good, nit:
Do we need too change something here? |
Another nit: datadog-lambda-python/CONTRIBUTING.md Line 27 in 8e74ac2
Maybe we can change this too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I debated this. With the poetry changes, users shouldn't be able to manually include this library in py3.7 functions so it's probably fine. Will remove |
…e ago
What does this PR do?
Python 3.7 is now in phase 1 deprecation, so we do not plan on releasing new features or fixes as there is no continued security or technical support from AWS, and we cannot create new 3.7 functions.
Motivation
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply