Skip to content

feat(breaking): ddtrace 2.3 #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2023
Merged

feat(breaking): ddtrace 2.3 #394

merged 2 commits into from
Nov 21, 2023

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Nov 21, 2023 •
edited
Loading

What does this PR do?

BREAKING - although we expect only minor disruptions to customers as the dropped/changed APIs are limited.

Motivation

1.x is maintenance only and 2.x includes new features including support for 128b trace IDs which won't be added to 1.x

Testing Guidelines

Full integration tests passing, self monitoring, and manual testing

Additional Notes

Migration guide is here: https://github.com/DataDog/dd-trace-py/releases/tag/v2.0.0

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@astuyve astuyve marked this pull request as ready for review November 21, 2023 15:37
@astuyve astuyve requested a review from a team as a code owner November 21, 2023 15:37
duncanista
duncanista approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – thanks for providing the migration guide.

@astuyve astuyve merged commit 7334375 into main Nov 21, 2023
@astuyve astuyve deleted the aj/128b-trace-id-ddtrace branch November 21, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanista duncanista duncanista approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@astuyve @duncanista