Skip to content

enhancing tag_object #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2023
Merged

enhancing tag_object #367

merged 2 commits into from
Sep 11, 2023

Conversation

joeyzhao2018
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 commented Sep 9, 2023

What does this PR do?

  1. Same as When capturing lambda payload, always cast number into string for sec… datadog-lambda-js#422.
  2. Enhanced the tag_object method further so that it can support chalice.app.response and other types so that the trace doesn't break when the DD_CAPTURE_LAMBDA_PAYLOAD enabled.

Motivation

  1. Same as When capturing lambda payload, always cast number into string for sec… datadog-lambda-js#422.
  2. https://datadoghq.atlassian.net/browse/SVLS-3522

Testing Guidelines

  1. This has been tested in us-west-2 in serverless sandbox account with joey-python-hello-world function
  2. This has been tested in us-west-1 in serverless sandbox account with helloworld-dev function
image

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@joeyzhao2018 joeyzhao2018 requested a review from a team as a code owner September 9, 2023 17:48
@joeyzhao2018 joeyzhao2018 self-assigned this Sep 9, 2023
@joeyzhao2018 joeyzhao2018 merged commit 080274d into main Sep 11, 2023
@joeyzhao2018 joeyzhao2018 deleted the joey/enhance_tag_object branch September 11, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants