Skip to content

feat: EventBridge to SQS support #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

duncanista
Copy link
Contributor

@duncanista duncanista commented Aug 4, 2023

What does this PR do?

Adds support for tracing payloads.

Motivation

It's possible to have distributed tracing on it, so why not?

Testing Guidelines

Added unit tests.
Also tested manually.

Screenshot 2023-08-04 at 8 20 53 PM

Additional Notes

Since EventBridge doesn't provide resolution in milliseconds, we end up with really large spans for it.
Maybe this can be fixed by adding a new field. Research is still needed for this.

Screenshot 2023-08-04 at 8 21 17 PM

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@duncanista duncanista marked this pull request as ready for review August 5, 2023 00:22
@duncanista duncanista requested a review from a team as a code owner August 5, 2023 00:22
Copy link
Contributor

@astuyve astuyve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple notes, but functionally this looks good!

@duncanista duncanista merged commit 63f7082 into main Aug 7, 2023
@duncanista duncanista deleted the jordan.gonzalez/SLS-3938/inferred-spans/propagate-context-on-eventbridge-triggers branch August 7, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants