add commit step before push #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zARODz11z
commented
Jun 22, 2023
| @@ -86,6 +86,7 @@ echo "Publishing to https://pypi.org/project/datadog-lambda/" | |||
|
|
|||
There was a problem hiding this comment.
see above we use the $NEW_VERSION var
astuyve
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
We were forgetting to commit the version change manually.
referenced: https://github.com/DataDog/datadog-lambda-js/blob/6809f4309678043559f255491658a64c9fe45bda/scripts/publish_prod.sh#L88-L89
Testing Guidelines
I had just ran a release before and noticed I can use the $NEW_VERSION variable
Additional Notes
Types of Changes
Check all that apply