Skip to content

fix: Ensure authorized span headers are injected as str #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

Wesitos
Copy link
Contributor

@Wesitos Wesitos commented Apr 17, 2023

What does this PR do?

It injects the authorizer span headers as a regular string instead of a byte string.

Motivation

The Python 3.7 lambda runtime can't serialize responses that contain byte strings.

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

The python3.7 runtime cannot serialize byte strings
@Wesitos Wesitos requested a review from a team as a code owner April 17, 2023 22:57
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting request changes here to block. We had to use encoding because

Injecting extra data to the original response can break invocations using cached authorization data. Symptoms: The first (authorizing) invocation succeeded. But the following requests received Internal Server Error messages.

Therefore, TODO on our side: we need to test the encode and decode case here. We should add the case to the the integration test.

Hi @Wesitos, could you please open an issue on the serialization problem mentioned in the description here so that we can have more information? Thank you in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants