Skip to content

use ddsaml2aws #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 15, 2023
Merged

use ddsaml2aws #301

merged 2 commits into from
Mar 15, 2023

Conversation

joeyzhao2018
Copy link
Contributor

What does this PR do?

replace saml2aws with ddsaml2aws
https://datadoghq.atlassian.net/wiki/spaces/ENG/pages/1842709292/US1-Fed+Access#CLI%2FTerraform-Access

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@joeyzhao2018 joeyzhao2018 requested a review from a team as a code owner February 27, 2023 21:01
@joeyzhao2018 joeyzhao2018 reopened this Feb 27, 2023
duncanista
duncanista approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joeyzhao2018 joeyzhao2018 merged commit 0630e09 into main Mar 15, 2023
@joeyzhao2018 joeyzhao2018 deleted the joey/use_ddsaml2aws branch March 15, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanista duncanista duncanista approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeyzhao2018 @duncanista