-
Notifications
You must be signed in to change notification settings - Fork 45
cold start tracing (python) #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this Joey. I think overall it's ready to go, just two comments.
Ship it! |
Hello, |
Hi @PierreKiwi - there's a blog post here and environment variables controlling the granularity of this feature are documented here for now, which will expand as we roll out support to new runtimes and integrations. Also if you have specific questions, feel free to ping me in our open slack: https://chat.datadoghq.com/ |
Thanks @astuyve ! |
No problem, it's great to hear from our users either way! Sorry for that, I'm working with our technical writers to further document these features more centrally. And yes, CDK is next on my list. If you've got specific questions, definitely reach out in slack and I'm happy to help answer anything specifically. I hope this helps you! |
What does this PR do?
Add Cold Start Tracing feature to Datadog lambda python layer.
This feature is already available in
datadog-lambda-js
layer and this is its PR link.Motivation
Showing the spans to indicate the time consumed by loading each modules can help users better understand the cold start causes.
Testing Guidelines
Deployed in a testing lambda.
DD_COLD_START_TRACING
=false
DD_MIN_COLD_START_DURATION
=80
DD_COLD_START_TRACE_SKIP_LIB
=ddtrace.internal.sampling,jsonschema
Additional Notes
Types of Changes
Check all that apply