Skip to content

issue 295 #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2023
Merged

issue 295 #296

merged 1 commit into from
Jan 24, 2023

Conversation

joeyzhao2018
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 commented Jan 20, 2023

What does this PR do?

  • First added a unittest case to replicate the issue
  • Add the is_authorizer_response helper method to duck-type the response in a pythonic way.

Motivation

Fix the issue that the str responses were not handled elegantly and causing traceback.print_exc

Testing Guidelines

Added a test case to make sure no matter the response type, no error thrown and no traceback.print_exe in normal case.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@joeyzhao2018 joeyzhao2018 requested a review from a team as a code owner January 20, 2023 21:02
@alexgallotta
Copy link

should there be a debug log or something in case DD_ENCODE_AUTHORIZER_CONTEXT is enabled but there is an error preventing the fields to be populated?

@joeyzhao2018 joeyzhao2018 changed the title Joey/issue 295 issue 295 Jan 24, 2023
@joeyzhao2018
Copy link
Contributor Author

should there be a debug log or something in case DD_ENCODE_AUTHORIZER_CONTEXT is enabled but there is an error preventing the fields to be populated?

Added the debug log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants