Skip to content

build: relax datadog version #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2023
Merged

build: relax datadog version #290

merged 1 commit into from
Jan 25, 2023

Conversation

filip-halemba
Copy link
Contributor

@filip-halemba filip-halemba commented Jan 2, 2023

What does this PR do?

Relaxing the datadog version requirement.

Motivation

It seems to me that the version is not intentionally locked to the range >= 0.41, < 0.42, and it is more a matter of the fact that poetry treats versions that start with 0 differently when using ^ (docs)

Testing Guidelines

Releases of the datadog lib (it looks to me that there is no risk):

Additional Notes

Related issue:

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

It seems to me that the version is not intentionally locked to the range >= 0.41, < 0.42, and it is more a matter of the fact that poetry treats versions that start with `0` differently when using `^` ([docs](https://python-poetry.org/docs/dependency-specification/#caret-requirements))

Related issue:
- DataDog#253

Releases of the `datadog` lib (it looks to me that there is no risk):
- https://github.com/DataDog/datadogpy/releases
@filip-halemba filip-halemba requested a review from a team as a code owner January 2, 2023 16:23
@astuyve astuyve merged commit c622a3c into DataDog:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants