Skip to content

use context.aws_request_id for the inferredSpan's request_id tag #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

joeyzhao2018
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 commented Nov 11, 2022

What does this PR do?

use context.aws_request_id for the inferredSpan's request_id tag

Motivation

This is a bug fix. Our convention is to use the context's aws_request_id for the request_id here. Nodejs version reference

The http payload's request Id can still be available with captureLambdaPayload option

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@joeyzhao2018 joeyzhao2018 requested a review from a team as a code owner November 11, 2022 15:25
@joeyzhao2018 joeyzhao2018 force-pushed the joey/fix-request-id-bug branch from 38ed790 to 49b61ae Compare December 3, 2022 03:16
Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@astuyve astuyve merged commit 5e8b8f6 into main Dec 6, 2022
@astuyve astuyve deleted the joey/fix-request-id-bug branch December 6, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants