Skip to content

Fix error when APIGateway headers are None #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

sfirrin
Copy link
Contributor

@sfirrin sfirrin commented Oct 28, 2022

What does this PR do?

Fixes #249 by allowing context["headers"] to be None and falling back to an empty {}

Motivation

#249

Testing Guidelines

Passes tests and added another for this case

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@sfirrin sfirrin requested a review from a team as a code owner October 28, 2022 19:25
@sfirrin sfirrin merged commit 549f7f8 into main Nov 2, 2022
@sfirrin sfirrin deleted the stephenf/fix-error-with-none-headers branch November 2, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoneType object has no attribute 'items'
2 participants