Skip to content

feat: Replace list with set #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2022
Merged

feat: Replace list with set #236

merged 1 commit into from
Jun 27, 2022

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Jun 27, 2022

What does this PR do?

We don't know what a user may bring to the event arg, as libraries ran before us (see #225) can rewrite it.
Although list responds to in, it wouldn't really let us access headers unless we knew the format of the list. But a set will, so this PR allows for a set instead, which does work with the underlying calls in extract_context_from_http_event_or_context

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@astuyve astuyve requested a review from a team as a code owner June 27, 2022 20:45
@astuyve astuyve requested a review from kimi-p June 27, 2022 20:45
Copy link
Contributor

@kimi-p kimi-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@astuyve astuyve merged commit 8c6ffec into main Jun 27, 2022
@astuyve astuyve deleted the aj/use-dict-instead-of-list branch June 27, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants