fix: type check event before treating it as a dict #233
Conversation
| @@ -332,7 +332,7 @@ def extract_dd_trace_context(event, lambda_context, extractor=None): | |||
| parent_id, | |||
| sampling_priority, | |||
| ) = extract_context_custom_extractor(extractor, event, lambda_context) | |||
| elif "headers" in event: | |||
| elif isinstance(event, (list, dict)) and "headers" in event: | |||
There was a problem hiding this comment.
@astuyve I'm wondering we should only check dict. Is it possible for list to contain Datadog trace context?
There was a problem hiding this comment.
I was trying to consider which data structures implement an iterable, but realize that list probably won't help us. I think I'm going to replace list with set, since another library might convert the event into a set instead of a dict.
There was a problem hiding this comment.
SG! Just for me own knowledge, do we have a doc that lists what lib might form event in what format?
There was a problem hiding this comment.
It varies wildly depending on the integration (see docs). But this library seems to have been written basically only for a Dict or Set type event - however Lambda allows the type of event to be None, binary data, or a few other options (including a list/array), and since we don't have an guarantee, we have to duck-type it.
What does this PR do?
fixes #232
fixes #225
Still need to extract WSGI payloads
Motivation
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply