Relax datadog version requirement #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the datadog package version is 0.x.y, `^0.41.0` is equivalent to `>= 0.41.0 <0.42.0` [1]. This currently locks the version to `0.41.y`. Newer versions of `datadog` have been released with minor changes (currently 0.44.0), but depending on this project prevents pulling them in. [1]: https://python-poetry.org/docs/dependency-specification/
alindeman
commented
Jun 23, 2022
| @@ -24,7 +24,7 @@ classifiers = [ | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = ">=3.6.0,<4" | |||
| datadog = "^0.41.0" | |||
| datadog = "^0.41" | |||
| wrapt = "^1.11.2" | |||
| ddtrace = "^0.61.1" | |||
There was a problem hiding this comment.
If this change is considered acceptable, we may also want to make a similar change for ddtrace which is also effectively locked to 0.61.y (y >= 1). I'd be happy to make that change if requested.
astuyve
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
Looks good to me! Thanks, feel free to raise a similar PR in dd-trace-py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The use of the caret requirement with a pre-1.0 package is effectively locking the
datadogpackage to a single version.This PR proposes allowing more recent versions of the
datadogpackage (e.g., 0.42.0, 0.43.0, etc).Motivation
I am trying to use this package in tandem with a different package that requires
datadog >= 0.42.0. But this package has effectively lockeddatadogto0.41.0so they are currently not compatible.Testing Guidelines
Changes are only to package requirements.
Additional Notes
Let me know if there are better ways to tackle this issue.
Types of Changes
Check all that apply