Run development tools rather than install them #4172
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "tool" directive of Go 1.24 ensures that tools use dependencies compatible with other packages in the same module. This is perfect for generated code and CRDs based on Go structs. This also bumps controller-gen to v0.17.3.
This makes it slightly easier to clone the project and immediately run tests. One may continue to use pre-installed tools by calling Make targets with the ENVTEST and KUTTL variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
Some Make targets download tools to
hack/toolswhile others expect them to be installed already.What is the new behavior (if this is a feature change)?
Run the tools for contributing code using
go runandgo tool. This reduces clutter in the project directory and lets Go cache and share these tools effectively across projects.