Skip to content

Add Ribbon View, Demo Fold Provider, Ribbon Toggles #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: feat/code-folding
Choose a base branch
from

Conversation

thecoolwinter
Copy link
Collaborator

@thecoolwinter thecoolwinter commented May 8, 2025

Description

Note

For reviewers, this is merging into the dev branch. These changes require the version of CETV in this PR. Please pull those changes locally and test using that.

Note

I'll be making some TODOs in the tracking issue #43 for things that aren't included here. Like the overlapping folds UI issue.

Adds the first version of the code folding ribbon, with a very basic folding model.

This is mostly a UI change. It includes changes to the gutter, and a new view for displaying folds. The model and related demo fold provider should be considered incomplete and only for demo purposes.

This also doesn't implement the hover state yet. Just a very basic outline of everything.

Things to review:

  • New FoldingRibbonView
  • New LineFoldingModel
  • Changes in GutterView
  • Changes to TextViewController
  • Changes to CodeEditSourceEditor

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Light mode.
Screenshot 2025-05-07 at 3 22 17 PM

Dark Mode.
Screenshot 2025-05-08 at 10 12 45 AM

Folds are transparent for scrolling text.
Screenshot 2025-05-08 at 10 08 35 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant