fix(enum): propagate namingConvention.transformUnderscore to convertNameParts #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Code-Hex I believe that job is failing since the action is running against my fork, and not your repository; thus the ref to |
|
+1 this PR, I just ran into these issues |
|
@Code-Hex This is ready for your review at your convenience. 🙏 |
|
@Code-Hex Howdy, apologies for the double ping -- hope all is well with you! Just wanting to be sure to bump this, as others are having this same issue. |
Code-Hex
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
@sutt0n I'm sorry for delay response.
LGTM but Could you apply format with eslint because failed it : https://github.com/Code-Hex/graphql-codegen-typescript-validation-schema/actions/runs/11238403086/job/31243096614?pr=828?
|
I can handle it 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I introduced
useEnumTypeAsDefaultValuevia #640, I failed to propagate this prop down and this resulted in no control over underscores.Docs are also updated.