Skip to content

add useTypeImports config #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 27, 2023
Merged

add useTypeImports config #377

merged 4 commits into from
May 27, 2023

Conversation

Toanzzz
Copy link
Contributor

@Toanzzz Toanzzz commented May 27, 2023

Resolve #376

@Code-Hex
Copy link
Owner

@Toanzzz Thanks for your contribution and suggestion!

Could you fix also yup and zod? (Not only myzod)

And please write test. So I can check your PR!

@Toanzzz
Copy link
Contributor Author

Toanzzz commented May 27, 2023

@Code-Hex Thanks for the reminder, I was quite in rush, sorry 😅

Updated & tested!

@Code-Hex
Copy link
Owner

@Toanzzz Could you please run yarn prettier on your local 🙏

@Toanzzz
Copy link
Contributor Author

Toanzzz commented May 27, 2023

@Toanzzz Could you please run yarn prettier on your local 🙏

It's done (I didn't know it was so strict)

Code-Hex
Code-Hex approved these changes May 27, 2023
View reviewed changes
Copy link
Owner

@Code-Hex Code-Hex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Code-Hex Code-Hex merged commit cbec0f8 into Code-Hex:main May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Code-Hex Code-Hex Code-Hex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option "useTypeImports"
2 participants
@Toanzzz @Code-Hex