Skip to content

fix: ObjectTypeDefinitionBuilder greedy matching ignore types #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2022
Merged

fix: ObjectTypeDefinitionBuilder greedy matching ignore types #168

merged 1 commit into from
Sep 2, 2022

Conversation

ctrlplusb
Copy link
Contributor

@ctrlplusb ctrlplusb commented Sep 1, 2022 •
edited
Loading

The Regex matcher for ObjectTypeDefinitionBuilder was greedy matching the ignore types.

Closes #167

@ctrlplusb ctrlplusb mentioned this pull request Sep 1, 2022
Closed
@ctrlplusb ctrlplusb force-pushed the fix/object-type-definition-builder branch from de7ec4d to 5706e59 Compare September 1, 2022 14:37
Code-Hex
Code-Hex approved these changes Sep 2, 2022
View reviewed changes
Copy link
Owner

@Code-Hex Code-Hex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Thank you!

@Code-Hex Code-Hex merged commit a684cc0 into Code-Hex:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Code-Hex Code-Hex Code-Hex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Any type with "Query" in its name gets ignored
2 participants
@ctrlplusb @Code-Hex