Skip to content

fix documentation for All, which actually returns false #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

nitram509
Copy link
Contributor

Please provide a brief description of the change.

The documentation for All in the README was wrong - the correct return value is false.

Which issue does this change relate to?

n/a

Contribution checklist.

Replace the space in each box with "X" to check it off.

  • I have read and understood the CONTRIBUTING guidelines
  • All commits in my PR conform to the commit hygiene section
  • I have added relevant tests
  • I have not added any dependencies

Additional context

n/a

@BooleanCat
Copy link
Owner

Good spot, thanks @nitram509

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (79c0d91) to head (e9ce5b8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #154   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           34        34           
  Lines          624       624           
=========================================
  Hits           624       624           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BooleanCat BooleanCat merged commit 83eb34e into BooleanCat:main Feb 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants