Skip to content

Communication Identity | Fixed next-pylint and mypy errors #30970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 13, 2023
Merged

Communication Identity | Fixed next-pylint and mypy errors #30970

merged 4 commits into from
Jul 13, 2023

Conversation

mjafferi-msft
Copy link
Member

Description

Made changes to improve Communication Identity modality code by running below formatters :

  • mypy(static type checker)
  • next-pylint

Next-Pylint :
tox run -e next-pylint -c eng/tox/tox.ini --root .\sdk\communication\azure-communication-identity
Your code has been rated at 10.00/10

Mypy :
mypy .\azure\communication\identity\
Success: no issues found in 35 source files

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mjafferi-msft
Copy link
Member Author

/azp run python - azure-communication-identity - tests

@mjafferi-msft
Copy link
Member Author

/azp run python - azure-communication-identity - tests-weekly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mjafferi-msft mjafferi-msft marked this pull request as ready for review June 30, 2023 12:39
@mjafferi-msft mjafferi-msft requested a review from l0lawrence June 30, 2023 12:39
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jun 30, 2023 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-communication-identity

l0lawrence
l0lawrence reviewed Jun 30, 2023
View reviewed changes
Copy link
Member

@l0lawrence l0lawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the pylint side for azure-communication-identity it looks good! A few small comments :)

kristapratico
kristapratico reviewed Jun 30, 2023
View reviewed changes
@mjafferi-msft mjafferi-msft merged commit 0b7c170 into Azure:main Jul 13, 2023
@mjafferi-msft mjafferi-msft deleted the code_formatters_mypy_pylint_updates branch July 13, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0lawrence l0lawrence l0lawrence left review comments

@kristapratico kristapratico kristapratico approved these changes

@AikoBB AikoBB Awaiting requested review from AikoBB AikoBB is a code owner

@maximrytych-ms maximrytych-ms Awaiting requested review from maximrytych-ms maximrytych-ms is a code owner

Assignees
No one assigned
Labels
Communication - Common Communication - Identity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjafferi-msft @azure-sdk @kristapratico @l0lawrence