Skip to content

Fix missing argument when specifying a --lib directory #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented Jul 17, 2019

As discovered in #714 the respective call to listFiles in asc when a directory was provided with --lib missed the necessary second parameter, leading to the described issue.

@dcodeIO
Copy link
Member Author

dcodeIO commented Jul 17, 2019

@jtenner: Can you confirm that this fixes the problem?

@jtenner
Copy link
Contributor

jtenner commented Jul 17, 2019

Should be about an hour. I'll confirm soon!

@jtenner
Copy link
Contributor

jtenner commented Jul 17, 2019

Confirmed. This fixes the problem.

I removed the top level import statement in the test, and Buffer was added as a global.

Thank you!

@dcodeIO dcodeIO merged commit ed52a6f into master Jul 17, 2019
@dcodeIO
Copy link
Member Author

dcodeIO commented Jul 17, 2019

Thanks for the confirmation! :)

@dcodeIO dcodeIO deleted the fix-lib-listFiles branch September 20, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants