Skip to content

fix: rest parameter crash resolver #2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 7, 2023

Conversation

HerrCai0907
Copy link
Member

Fixes #2707

Copy link
Member

@CountBleck CountBleck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in resolver.ts looks fine, but can't more functionality be tested (i.e. calling the function with 0-3 arguments)? If there are crashes from that, those should become errors.

@CountBleck
Copy link
Member

@HerrCai0907 Try git commit --amend --no-edit and git push -f to re-run CI.

@HerrCai0907
Copy link
Member Author

calling the function with 0-3 arguments

It is invalid code in current AS. rest parameter is not supported yet.

Copy link
Member

@CountBleck CountBleck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a func(1, 2, 3, 4) in the test. Then, the presence of the "Not implemented: Rest parameters" error can be checked in the stderr (and the 2707.{debug,release}.wat should be removed).

@HerrCai0907 HerrCai0907 requested a review from CountBleck October 3, 2023 00:38
@HerrCai0907 HerrCai0907 merged commit e3e4166 into AssemblyScript:main Oct 7, 2023
@HerrCai0907 HerrCai0907 deleted the fix/#2707 branch October 7, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crash during compile
2 participants