Ensure call-less references to builtin functions in namespaces error #2738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The equivalent check exists for identifiers, so I ripped that same code and inserted it in compilePropertyAccessExpression. While this is technically a fix for AssemblyScript#2737, we're not quite done yet.
This commit uses the same approach from the previous one: yoinking code from compileIdentifierExpression. This actually has no influence on the example in AssemblyScript#2737, but I can say this commit truly fixes AssemblyScript#2737 in spirit.
HerrCai0907
approved these changes
Sep 27, 2023
This was
linked to
issues
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
⯈ Fix the long-standing bug where the compiler cries when referencing a generic namespaced function.
⯈ Error when builtin functions in namespaces are referenced without being called.