ci: add missing feature test case in action #2723
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maaaaaaaayyyybeeeeeee, but I think maybe I could try something else... |
|
The main disadvantage is how there could be more tests utilizing ASC_FEATURES in the future, and if I added them, I doubt I would remember to add them to that list in CI 😛. Then, someone might wonder why a bunch of unrelated changes were included when they implement/touch that feature and run those tests. Also, if the compiler is modified and that somehow breaks one of those tests, it'll be harder to uncover why if the PR that caused that breakage can't be found from |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add missing feature test case
@CountBleck Could we fix test like this?