Skip to content

fix: Cannot find global type 'CallableFunction' #2712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix: Cannot find global type 'CallableFunction' #2712

merged 1 commit into from
Oct 10, 2023

Conversation

XMadrid
Copy link
Contributor

@XMadrid XMadrid commented Jun 21, 2023

Fixes #2646

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

CountBleck
CountBleck requested changes Sep 29, 2023
View reviewed changes
Copy link
Member

@CountBleck CountBleck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to manually specify some changes to improve the call/bind/apply typings, but it looks like microsoft/TypeScript@33ab6fd has exactly what I mean.

Using A extends any[] and ...args: A allows functions with any number and type of arguments to match, which removes unnecessary bloat.

Edit: sorry for the three-month delay!

@XMadrid XMadrid force-pushed the fix/cannot-find-CallableFunction branch from 1189eb4 to 4042530 Compare October 10, 2023 07:31
@XMadrid
Copy link
Contributor Author

XMadrid commented Oct 10, 2023

I was going to manually specify some changes to improve the call/bind/apply typings, but it looks like microsoft/TypeScript@33ab6fd has exactly what I mean.

Using A extends any[] and ...args: A allows functions with any number and type of arguments to match, which removes unnecessary bloat.

Edit: sorry for the three-month delay!

Okay, I aligned the declaration with the newest typescript/src/lib/es5.d.ts.

@XMadrid XMadrid requested a review from CountBleck October 10, 2023 07:34
@CountBleck CountBleck merged commit c22c078 into AssemblyScript:main Oct 10, 2023
@XMadrid XMadrid deleted the fix/cannot-find-CallableFunction branch April 3, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CountBleck CountBleck CountBleck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot find global type 'CallableFunction'
2 participants
@XMadrid @CountBleck