Skip to content

Fix fromCharCodes & fromCodePoints polyfills #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 14, 2020
Merged

Fix fromCharCodes & fromCodePoints polyfills #1340

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5129999
Use batching for fromCharCodes & fromCodePoints polyfills
MaxGraey Jun 14, 2020
fe49f87
reduce chunk size to 1 << 13
MaxGraey Jun 14, 2020
1b02f2f
fix
MaxGraey Jun 14, 2020
b3d9da5
what if 1 << 15 ?
MaxGraey Jun 14, 2020
8ce29c0
what if?
MaxGraey Jun 14, 2020
2529ce0
cleanups
MaxGraey Jun 14, 2020
96f607e
fix
MaxGraey Jun 14, 2020
aa5119f
revert
MaxGraey Jun 14, 2020
39f71a5
fix
MaxGraey Jun 14, 2020
9ab782c
back to 1 << 13
MaxGraey Jun 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions std/portable/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,39 @@ globalScope["changetype"] = function changetype(value) {
};

String["fromCharCodes"] = function fromCharCodes(arr) {
return String.fromCharCode.apply(String, arr);
const CHUNKSIZE = 1 << 13;
const len = arr.length;
if (len <= CHUNKSIZE) {
return String.fromCharCode.apply(String, arr);
}
let index = 0;
let parts = '';
while (index < len) {
parts += String.fromCharCode.apply(
String,
arr.slice(index, Math.min(index + CHUNKSIZE, len))
);
index += CHUNKSIZE;
}
return parts;
};

String["fromCodePoints"] = function fromCodePoints(arr) {
return String.fromCodePoint.apply(String, arr);
const CHUNKSIZE = 1 << 13;
const len = arr.length;
if (len <= CHUNKSIZE) {
return String.fromCodePoint.apply(String, arr);
}
let index = 0;
let parts = '';
while (index < len) {
parts += String.fromCodePoint.apply(
String,
arr.slice(index, Math.min(index + CHUNKSIZE, len))
);
index += CHUNKSIZE;
}
return parts;
};

if (!String.prototype.replaceAll) {
Expand Down