Skip to content

peerDependencies installed but still shows warning #5007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sibiraj-s opened this issue Nov 28, 2017 · 1 comment
Closed

peerDependencies installed but still shows warning #5007

sibiraj-s opened this issue Nov 28, 2017 · 1 comment
Assignees
Labels

Comments

@sibiraj-s
Copy link

sibiraj-s commented Nov 28, 2017

Do you want to request a feature or report a bug?
A Bug I guess

What is the current behaviour?

  "devDependencies": {
    "@angular/animations": "^5.0.0",
    "@angular/cli": "1.5.4",
    "@angular/common": "^5.0.0",
    "@angular/compiler": "^5.0.0",
    "@angular/compiler-cli": "^5.0.0",
    "@angular/core": "^5.0.0",
    "@angular/forms": "^5.0.0",
    "@angular/http": "^5.0.0",
    "@angular/language-service": "^5.0.0",
    "@angular/platform-browser": "^5.0.0",
    "@angular/platform-browser-dynamic": "^5.0.0",
    "@angular/router": "^5.0.0",
    "@types/jasmine": "~2.5.53",
    "@types/jasminewd2": "~2.0.2",
    "@types/node": "~6.0.60",
    "bootstrap": "^4.0.0-beta.2",
    "codelyzer": "^4.0.1",
    "commitizen": "^2.9.6",
    "core-js": "^2.4.1",
    "jasmine-core": "~2.6.2",
    "jasmine-spec-reporter": "~4.1.0",
    "karma": "~1.7.0",
    "karma-chrome-launcher": "~2.1.1",
    "karma-cli": "~1.0.1",
    "karma-coverage-istanbul-reporter": "^1.2.1",
    "karma-jasmine": "~1.1.0",
    "karma-jasmine-html-reporter": "^0.2.2",
    "protractor": "~5.1.2",
    "rxjs": "^5.5.2",
    "ts-node": "~3.2.0",
    "tslint": "~5.7.0",
    "typescript": "~2.4.2",
    "zone.js": "^0.8.14"
  }

These are the dependencies I have. Here angular/core, common requires a peer dependency of rxjs.
I have also mentioned that as a dependency but still getting a warning.

warning " > @angular/[email protected]" has unmet peer dependency "rxjs@^5.5.0".
warning " > @angular/[email protected]" has unmet peer dependency "rxjs@^5.5.0".
warning " > @angular/[email protected]" has unmet peer dependency "zone.js@^0.8.4".

But works well while installing with npm

What is the expected behaviour?
I think it should not show the warning when dependencies are installed.

Please mention your node.js, yarn and operating system version.

Nodejs : 8.9.1
OS: Ubuntu 17.10
yarn : 1.3.2

@ghost ghost assigned bestander Nov 28, 2017
@ghost ghost added the triaged label Nov 28, 2017
@rally25rs
Copy link
Contributor

rally25rs commented Nov 28, 2017

duplicate #4743

There is a known issue where Yarn is failing to look at the top-level dependencies in package.json when checking for peerDeps. There is a fix being worked on...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants