Skip to content

Support --nohoist option for workspaces. #4049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
richburdon opened this issue Jul 29, 2017 · 3 comments
Closed

Support --nohoist option for workspaces. #4049

richburdon opened this issue Jul 29, 2017 · 3 comments

Comments

@richburdon
Copy link

Feature:

Workspaces currently hoist everything to the root level. lerna supports a --nohoist option to leave modules that match a regex in the packages/sub/node_modules folder.

For example, grunt requires that all plugins are in the local node_modules directory.

@MoOx
Copy link

MoOx commented Aug 20, 2017

I have this problem when using reasonml packages.
Some of my packages of my workspace require bs-platform + some others other of my own, as deps, but with everything at the root, bsb is throwing some fatal errors like (since you have bsb-platform at the root of the project): Error: Unbound module Pervasives (bs-platform does not like to be relocated).
I tried to add older version at the root of the project so the right version is in the right place for my package and I then got BSB check build spec : Dependencies information missing because some deps are not at the right place for bsb. Using a nohoist glob or something like lerna will make it usable for reasonml packages.


EDIT: not sure what I did (maybe cleaning all node_modules folder) but I think this entire problem happened because some previous folder where messed up)

@MoOx
Copy link

MoOx commented Aug 20, 2017

This issue feature request is probably a dupe of #3882

@BYK
Copy link
Member

BYK commented Aug 21, 2017

Duplicate of #3882.

@BYK BYK closed this as completed Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants