Skip to content
This repository was archived by the owner on Jan 26, 2019. It is now read-only.

Commit 52fbee9

Browse files
authored
Merge pull request #104 from wmonk/facebook-1.0.10
Facebook 1.0.10
2 parents 7304c24 + 3afca81 commit 52fbee9

File tree

81 files changed

+1908
-552
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

81 files changed

+1908
-552
lines changed

.github/ISSUE_TEMPLATE.md

Lines changed: 165 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,165 @@
1+
<!--
2+
PLEASE READ THE FIRST SECTION :-)
3+
-->
4+
5+
### Is this a bug report?
6+
7+
(write your answer here)
8+
9+
<!--
10+
If you answered "Yes":
11+
12+
Please note that your issue will be fixed much faster if you spend about
13+
half an hour preparing it, including the exact reproduction steps and a demo.
14+
15+
If you're in a hurry or don't feel confident, it's fine to report bugs with
16+
less details, but this makes it less likely they'll get fixed soon.
17+
18+
In either case, please fill as many fields below as you can.
19+
20+
If you answered "No":
21+
22+
If this is a question or a discussion, you may delete this template and write in a free form.
23+
Note that we don't provide help for webpack questions after ejecting.
24+
You can find webpack docs at https://webpack.js.org/.
25+
-->
26+
27+
28+
### Can you also reproduce the problem with npm 4.x?
29+
30+
<!--
31+
Many errors, especially related to "missing modules", are due to npm bugs.
32+
Which version of npm are you running? You can find out by checking:
33+
34+
npm -v
35+
36+
If it is 5.x, please be aware that it has more than 50 known bugs, and
37+
is not guaranteed to work with Create React App.
38+
39+
If it's not starting with 4, try to install npm 4.x:
40+
41+
npm install -g npm@4
42+
cd your_project_directory
43+
rm -rf node_modules
44+
npm cache clear
45+
npm install
46+
47+
Then try to reproduce the issue again.
48+
Can you still reproduce it?
49+
50+
Note: Please try this even if you are using Yarn so that we know whether it's a Yarn-only bug.
51+
-->
52+
53+
(Write your answer here.)
54+
55+
56+
### Which terms did you search for in User Guide?
57+
58+
<!--
59+
There are a few common documented problems, such as watcher not detecting changes, or build failing.
60+
They are described in the Troubleshooting section of the User Guide:
61+
62+
https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#troubleshooting
63+
64+
Please scan these few sections for common problems.
65+
Additionally, you can search the User Guide itself for something you're having issues with:
66+
67+
https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md
68+
69+
If you didn't find the solution, please share which words you searched for.
70+
This helps us improve documentation for future readers who might encounter the same problem.
71+
-->
72+
73+
(Write your answer here if relevant.)
74+
75+
76+
### Environment
77+
78+
<!--
79+
Please fill in all the relevant fields by running these commands in terminal.
80+
-->
81+
82+
1. `npm ls react-scripts-ts` (if you haven’t ejected):
83+
2. `node -v`:
84+
3. `npm -v`:
85+
4. `yarn --version` (if you use Yarn):
86+
<<<<<<< HEAD
87+
5. `npm ls react-scripts` (if you haven’t ejected):
88+
=======
89+
3. `npm ls react-scripts-ts` (if you haven’t ejected):
90+
>>>>>>> Fix Code Review
91+
92+
Then, specify:
93+
94+
1. Operating system:
95+
2. Browser and version (if relevant):
96+
97+
98+
### Steps to Reproduce
99+
100+
<!--
101+
How would you describe your issue to someone who doesn’t know you or your project?
102+
Try to write a sequence of steps that anybody can repeat to see the issue.
103+
-->
104+
105+
(Write your steps here:)
106+
107+
1.
108+
2.
109+
3.
110+
111+
112+
### Expected Behavior
113+
114+
<!--
115+
How did you expect the tool to behave?
116+
It’s fine if you’re not sure your understanding is correct.
117+
Just write down what you thought would happen.
118+
-->
119+
120+
(Write what you thought would happen.)
121+
122+
123+
### Actual Behavior
124+
125+
<!--
126+
Did something go wrong?
127+
Is something broken, or not behaving as you expected?
128+
Please attach screenshots if possible! They are extremely helpful for diagnosing issues.
129+
-->
130+
131+
(Write what happened. Please add screenshots!)
132+
133+
134+
### Reproducible Demo
135+
136+
<!--
137+
If you can, please share a project that reproduces the issue.
138+
This is the single most effective way to get an issue fixed soon.
139+
140+
There are two ways to do it:
141+
142+
* Create a new app and try to reproduce the issue in it.
143+
This is useful if you roughly know where the problem is, or can’t share the real code.
144+
145+
* Or, copy your app and remove things until you’re left with the minimal reproducible demo.
146+
This is useful for finding the root cause. You may then optionally create a new project.
147+
148+
This is a good guide to creating bug demos: https://stackoverflow.com/help/mcve
149+
Once you’re done, push the project to GitHub and paste the link to it below:
150+
-->
151+
152+
(Paste the link to an example project and exact instructions to reproduce the issue.)
153+
154+
<!--
155+
What happens if you skip this step?
156+
157+
We will try to help you, but in many cases it is impossible because crucial
158+
information is missing. In that case we'll tag an issue as having a low priority,
159+
and eventually close it if there is no clear direction.
160+
161+
We still appreciate the report though, as eventually somebody else might
162+
create a reproducible example for it.
163+
164+
Thanks for helping us help you!
165+
-->

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<!--
2+
Thank you for sending the PR!
3+
4+
If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots!
5+
6+
Happy contributing!
7+
-->

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
language: node_js
33
node_js:
44
- 6
5-
- 7
5+
- 8
66
cache:
77
directories:
88
- node_modules

0 commit comments

Comments
 (0)