Skip to content

Commit a3c9ab0

Browse files
nielsdoscharmitro
authored andcommitted
Fix phpGH-17847: xinclude destroys live node
dom_xinclude_strip_fallback_references() now also takes into account xi:include nodes children. This now subsumes all work done normally by the old start/end node removal, so we can remove that code and start using XML_PARSE_NOXINCNODE. Closes phpGH-17878.
1 parent e6a7d5f commit a3c9ab0

File tree

3 files changed

+570
-641
lines changed

3 files changed

+570
-641
lines changed

NEWS

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ PHP NEWS
1616
. Fixed bug GH-17797 (zend_test_compile_string crash on invalid
1717
script path). (David Carlier)
1818

19+
- DOM:
20+
. Fixed bug GH-17847 (xinclude destroys live node). (nielsdos)
21+
1922
- FFI:
2023
. Fix FFI Parsing of Pointer Declaration Lists. (davnotdev)
2124

0 commit comments

Comments
 (0)