-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Last version of js-beautify breaks vue-cli installation #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
For a quick fix, you can install yarn and run |
Seems this has to be solved in js-beautify. Good to know that yarn seems to work, though I wonder why. |
@LinusBorg https://github.com/vuejs/vue-cli/blob/master/yarn.lock#L3192. Edit: |
@jddxf thanks, yarn works. |
@jddxf I think an npm-shrinkwrap.json would be even better in this case: command line tools (such as vue-cli) are among the recommended use-cases mentioned in npm official documentation:
|
@LucaBlackDragon You're right. I didn't realize the difference between
So having a |
@LucaBlackDragon That's a good point, we should think about using that. /cc @vuejs/collaborators do you have any thoughts on this one? |
yarn not install with npm but with the msi in win10 can install the cli successfully |
Vue-cli doesn't depend on js-beautify directly. But some dependency bumped its dependency on js-beautify and that breaks us. I would give a thumb up for npm-shirnkwrap.json, which is designed for avoiding such scenario.
|
@HerringtonDarkholme hmm lockfile actually wouldn't work for end users, I think you mean npm-shrinkwrap.json |
@egoist Sure. Thanks for correction. |
Pull request is up, just needs permission to merge: beautifier/js-beautify#1251 |
dup of #591 |
Steps to reproduce:
Run
npm i -g vue-cli
in terminalExpected behavior:
vue-cli should install
Actual behavior:
The installation fails and this error is logged:
Notes:
An issue has already been opened in js-beautify repo:
beautifier/js-beautify#1247
The text was updated successfully, but these errors were encountered: