Skip to content

Add event union type to trigger method #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nandi95 opened this issue Feb 23, 2021 · 5 comments · Fixed by #551
Closed

Add event union type to trigger method #415

nandi95 opened this issue Feb 23, 2021 · 5 comments · Fixed by #551

Comments

@nandi95
Copy link
Contributor

nandi95 commented Feb 23, 2021

This will give us nice, typehints of the possible values.

The dom-event-type already includes the keys that can be triggered.
would as const and keyof work to extract the keys from that package?

Are some of it needs to be filtered out?

@cexbrayat
Copy link
Member

That sounds like a nice idea, go ahead with a PR 👍

@nandi95
Copy link
Contributor Author

nandi95 commented Feb 25, 2021

Linked issue

@lmiller1990
Copy link
Member

We can probably inline the entire dom-event-types lib? No real point having a static list of events as a dependency, and then we can improve the types and the such. What do you think?

@nandi95
Copy link
Contributor Author

nandi95 commented Mar 3, 2021

That would work as a quick fix for sure. My preference that it's a dependency that others can pull in too. However that library doesn't seem to be active anymore so I'm not sure.

@lmiller1990
Copy link
Member

That lib is actually by one of the original maintainers of Test Utils and has moved on from the front-end world - I don't expect it will see an update or release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants