-
Notifications
You must be signed in to change notification settings - Fork 264
Add event union type to trigger method #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
That sounds like a nice idea, go ahead with a PR 👍 |
We can probably inline the entire dom-event-types lib? No real point having a static list of events as a dependency, and then we can improve the types and the such. What do you think? |
That would work as a quick fix for sure. My preference that it's a dependency that others can pull in too. However that library doesn't seem to be active anymore so I'm not sure. |
That lib is actually by one of the original maintainers of Test Utils and has moved on from the front-end world - I don't expect it will see an update or release. |
This will give us nice, typehints of the possible values.
The dom-event-type already includes the keys that can be triggered.
would
as const
andkeyof
work to extract the keys from that package?Are some of it needs to be filtered out?
The text was updated successfully, but these errors were encountered: